Repository navigation
Add hard test deadlines and cap all CI/release jobs - #1463
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b389d7442
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9590395af8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 93b4ae0d95
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c626eb004
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 292aa15f6b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
An uninterruptible test or modal dialog could leave a test worker running until Actions consumed hours of runner time. Compiler test/configuration invocations now have a 3-minute watchdog; helpers have a 1-minute watchdog, below their 2-minute suite cap. It preserves the original test thread, prints the method and thread stacks directly to stderr, and terminates the worker with exit 124. An independent hard exit prevents diagnostic output or shutdown hooks from blocking termination.
Compiler/helper test tasks are capped at 20/2 minutes; stdlib fetching and AST generation at 5 minutes. Test steps have separate deadlines. Every CI job is capped at 25 minutes; release validation/packaging/publication at 5/35/10 minutes. Suites and matrices fail fast. A CI policy regression rejects workflows containing unbounded jobs or caps above 35 minutes.
Validation: subprocess regressions cover uninterruptible test/setup methods, blocked diagnostics, and canceled deadlines; focused watchdog/model-reuse tests and HelperScripts tests pass. A real Gradle worker timeout with a 100ms budget fails with exit 124 and leaves its thread dump visible under --quiet. A temporary 1-second suite budget also fails promptly. All five workflow-policy checks pass. The full Windows suite passes: 2,595 tests, zero failures, about 4.5 minutes with two forks. Final focused validation passes all 43 watchdog/model-reuse cases and all 7 helper tests. Linux PR CI passed on final head 292aa15. macOS and release packaging have not been run locally.
A forcibly terminated worker loses its pending XML report; its diagnostic is retained in the job log. Deliberate longer local invocations can use -PtestTimeoutMillis; Actions caps remain independent.