Repository navigation
Fix Windows object-export test and document cross-OS footguns - #1465
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master CI failed on Windows because the new object-export test compared path spelling: the temp directory used
RUNNER~1whileWFilereturned the canonicalrunneradminpath. Compare existing file identity withFiles.isSameFile, and include./in the expected path so the old assertion fails on any host.Add cross-OS responsibilities to AGENTS.md and a linked footgun reference covering path aliases, interactive game discovery, runtime packaging, tool dependencies, and process/text boundaries. Agents must inspect relevant host assumptions and report unverified platforms. PR CI stays Ubuntu-only; no workflow or repository settings changes.
Validation: the alias repro failed before the fix; all 36 MapModelReuseTests cases pass on Windows with Java 27 after the fix.
git diff --checkpasses. Linux/macOS execution was not run locally. The existing Ubuntu PR job supplies its normal checks.