Repository navigation
feat(compositor): the Linux pass of shader effects - #1207
Closed
EtienneLescot wants to merge 0 commit into
Closed
EtienneLescot wants to merge 0 commit into
EtienneLescot wants to merge 0 commit into
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 14, 2026
EtienneLescot
changed the base branch from
feat/shader-effects-contract
to
integration/shader-effects
October 14, 2026 15:54
EtienneLescot
force-pushed
the
feat/shader-effects-linux
branch
from
October 14, 2026 15:55
9ab07ce to
a607e20
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Linux pass of agent-written shader effects: the wgpu compositor now draws them, as the Windows one does since #1199. This is section L.4 of
docs/shader-effects.md. Stacked on #1199: it only needs that PR's Rust, not the document of #1202.image,texton a transparent text layer,both), lanes, a 64-entry cache. The export waits for a pending compile; the live view skips the effect until it lands, then recomposes (live.rsnow turns that on for Linux too).on_uncaptured_erroris set.analyzenow refuses any@bindingthe prelude does not declare, with its line, so nothing invalid reaches wgpu. A panic would only kill the compile thread anyway, leaving the effect undrawn.check_for_agenttranslates the effect to SPIR-V on Linux, as wgpu will.native-compositor.mdnow says macOS only; the spec (D.5, C.7, H.2) andrendering-performance.mdget the Linux details and the lavapipe calibration.Without a GPU, effects are expensive. On lavapipe a
frame()read costs about 1.4 ms per 1080p frame, 350 times an RTX 4070 Ti: a light effect already doubles the frame time. The tiers keep their order.Related issue
None.
Type of change
Release impact
Desktop impact
Testing
On lavapipe under WSL (nix
compositor-viewshell, Mesa'slvpICD):compositor_linux.rs: region repaint, preview non-blocking thenshader_fx_landed, broken / extra-binding / unknown-contract effects leave the frame untouched, colour parameter, lane order, the three targets. Run with--nocapture: none skipped.cargo test -p openscreen-compositor --lib --tests: all green (479 unit tests, plus the integration tests).shader_fx_tier_calibrationin release (OPENSCREEN_FX_BENCH=1) for the numbers above.On Windows:
cargo test -p openscreen-compositor --lib shader, 28 tests green.Not run: the app end to end on a Linux desktop, and an integrated GPU.
🤖 Generated with Claude Code